Changed the partition_status chunked_fifo chunk size to 8
#16247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisdowns
previously approved these changes
Jan 23, 2024
StephanDollberg
previously approved these changes
Jan 23, 2024
andrwng
previously approved these changes
Jan 23, 2024
We basically want a structure has the memory usage of |
mmaslankaprv
dismissed stale reviews from andrwng, StephanDollberg, and travisdowns
via
14ae4c7
mmaslankaprv
force-pushed
the
partition_status_chunk
branch
from
ca1ba12
to
14ae4c7
Compare
StephanDollberg
previously approved these changes
Jan 23, 2024
andrwng
previously approved these changes
Jan 23, 2024
|
Still see some build failures |
Signed-off-by: Michal Maslanka <michal@redpanda.com>
Signed-off-by: Michal Maslanka <michal@redpanda.com>
With large number of topics that contain a small amount of partitions we may end up wasting a lot of memory using the default `ss::chunked_fifo` chunk size of 128. Change the chunk size of `partition_status` `chunked_fifo` collection to 8 to minimize a waste with large number of small topics. Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
dismissed stale reviews from andrwng and StephanDollberg
via
75c9549
mmaslankaprv
force-pushed
the
partition_status_chunk
branch
from
14ae4c7
to
75c9549
Compare
StephanDollberg
approved these changes
Jan 24, 2024
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/44200#018d3aca-a16c-4738-b7e9-91579f903e8f |
|
/backport v23.3.x |
|
/backport v23.2.x |
This was referenced Jan 24, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With large number of topics that contain a small amount of partitions we
may end up wasting a lot of memory using the default
ss::chunked_fifochunk size of 128.
Change the chunk size of
partition_statuschunked_fifocollection to8 to minimize a waste with large number of small topics.
Backports Required
Release Notes
Improvements