Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: fix linter error #16260

Merged
merged 1 commit into from
Jan 23, 2024
Merged

lint: fix linter error #16260

merged 1 commit into from
Jan 23, 2024

Conversation

rockwotj
Copy link
Contributor

@rockwotj rockwotj commented Jan 23, 2024 •
edited by ivotron

This is failing on dev

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

@rockwotj
lint: fix linter error
6f274dc 
This was missed in a force merge

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@rockwotj rockwotj requested a review from a team as a code owner January 23, 2024 22:46
@rockwotj rockwotj requested review from savex and removed request for a team January 23, 2024 22:46
@rockwotj rockwotj mentioned this pull request Jan 23, 2024
Merged
7 tasks
@ivotron ivotron mentioned this pull request Jan 23, 2024
Closed
7 tasks
@rockwotj rockwotj requested a review from ivotron January 23, 2024 22:51
@piyushredpanda piyushredpanda merged commit 08583d5 into redpanda-data:dev Jan 23, 2024
16 of 18 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v23.3.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-16260-v23.3.x-674 remotes/upstream/v23.3.x
git cherry-pick -x 6f274dc24f80016818d52e9899dfe55a2073ba4a

Workflow run logs.

@vbotbuildovich vbotbuildovich mentioned this pull request Jan 23, 2024
Closed
@rockwotj rockwotj deleted the lint-bash branch January 23, 2024 23:33
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jan 24, 2024 •
edited

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/44180#018d38c0-f8ca-4183-b3ee-d084267336a5

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/44180#018d38c0-f8d2-41e4-8b65-8ce4d6ee31e7

@r-vasquez r-vasquez mentioned this pull request Feb 29, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivotron ivotron ivotron approved these changes

@savex savex Awaiting requested review from savex savex is a code owner automatically assigned from redpanda-data/devprod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rockwotj @vbotbuildovich @ivotron @piyushredpanda