Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: fix kafka_max_offset on read replicas #16263

Merged
merged 2 commits into from
Jan 24, 2024
Merged

metrics: fix kafka_max_offset on read replicas #16263

merged 2 commits into from
Jan 24, 2024

Commits on Jan 24, 2024

  1. rptest: fix redpanda metrics filtering 

    Updates the filter used when collecting metrics samples.

In some cases, the samples take the form:

Sample(name='redpanda_kafka_max_offset', labels={'redpanda_namespace': 'kafka', 'redpanda_partition': '5', 'redpanda_topic': 'panda-topic'}, value=0.0, ...
    @andrwng
    andrwng committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    e567d63 View commit details
    Browse the repository at this point in the history

  2. metrics: fix kafka_max_offset on read replicas 

    Read replicas were previously translating their own local log offsets to
return `redpanda_kafka_max_offset` to the metrics endpoint. This is
different from how read replicas calculate the HWM when returning to the
Kafka endpoint, which just goes directly to cloud storage.

This adds the same read replica check that we have in the Kafka layer.
    @andrwng
    andrwng committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    7e33cc7 View commit details
    Browse the repository at this point in the history