[v23.2.x] cloud_storage: hold gate in hydration #16282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most places were already holding the gate external to calls of hydrate() with the exception of aborted_transactions(). This commit fixes this by: - holding the gate during aborted_transactions() - making hydrate() hold the gate for the duration of its future (cherry picked from commit 0aefe35)
|
|
7 tasks
abhijat
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most places were already holding the gate external to calls of hydrate() with the exception of aborted_transactions(). This commit fixes this by:
(cherry picked from commit 0aefe35)
Fixes #15708
Backports Required
Release Notes