cloud_storage_compaction_test: a couple test fixes #16284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was conditioned on ensuring no data was uploaded on the read replica cluster, but it was using metrics from the source cluster to do this check. This fixes this to use the right cluster.
The test ensures that we don't upload from the read replica topics, but it unintentionally does do uploads from consumer offsets topics. This commit changes the behavior of the test to explicitly create the topic without tiered storage.
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/44258#018d3e7a-daee-4500-ab66-7a6f77e85659 |
|
/cdt |
andijcr
approved these changes
Jan 25, 2024
| @@ -211,12 +219,12 @@ def test_read_from_replica(self, cloud_storage_type): | |||
|
|
|||
| # read replica success and failures | |||
| rr_upload_successes = sum([ | |||
| sample.value for sample in self.redpanda.metrics_sample( | |||
| sample.value for sample in self.rr_cluster.metrics_sample( | |||
| "cloud_storage_successful_uploads", | |||
| metrics_endpoint=MetricsEndpoint.METRICS).samples | |||
| ]) | |||
There was a problem hiding this comment.
i'm curious how it was able to work, before this change
There was a problem hiding this comment.
I don't think this check worked before, but it made its way in because cdt isn't run by default for PRs
|
The test passed in CDT Other CI failures are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple issues with this test:
Fixes #16008
Backports Required
Release Notes