[v23.3.x] "enable by default spillover manifest" testing followups #16292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a previoud change interpreted a {"name": None} meaning that "name"
should be removed in the properties. but this does not work for optional
properties, they will revert to the default value.
the fix is to just pass it in the update field, the property will be
correctly set to nullopt
(cherry picked from commit 604dd39)
(cherry picked from commit ca81769)
(cherry picked from commit 45796ff)
(cherry picked from commit 0417d5c)
(cherry picked from commit 296a0c8)
Lazin
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #16248
Fixes #16291