[v23.3.x] transform-sdk/rust: borrow output record #16294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only need to borrow the output record. To do that we make the writer take `Into<BorrowedRecord<'_>>`, so that it can take any type of record for transforms (we can now do no copy transforms!). Since `Into<_>` is a trait, we can't have a monomorphic trait take a monomorphic trait as a function argument (see https://doc.rust-lang.org/reference/items/traits.html#object-safety). So we wrap our current trait in a struct that handles resolving the trait argument to the concrete type our write function will take. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com> (cherry picked from commit 6cd47a8)
Reuse input and output buffers for better performance. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com> (cherry picked from commit b5c5806)
Add the same docs we have for Golang, but in Rust. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com> (cherry picked from commit 66b3aed)
vbotbuildovich
requested review from
twmb,
r-vasquez and
gene-redpanda
as code owners
rockwotj
approved these changes
Jan 26, 2024
|
CI Failures: #16026 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #16210