Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapped logging with vlog macro in places that missed it #16304

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Wrapped logging with vlog macro in places that missed it #16304

merged 2 commits into from
Jan 29, 2024

Conversation

mmaslankaprv
Copy link
Member

@mmaslankaprv mmaslankaprv commented Jan 26, 2024 •
edited

Added missing vlog macros in places where logger was used without it. This way we will have log entry format consistent.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

@mmaslankaprv
c/partition_manager: wrapped shutdown error log with vlog
d0ee2f8 
Signed-off-by: Michal Maslanka <michal@redpanda.com>
@mmaslankaprv
rpc: wrapped logging with vlog macro
92228fb 
Signed-off-by: Michal Maslanka <michal@redpanda.com>
@mmaslankaprv
Copy link
Member Author

ci failure: #16308

@mmaslankaprv mmaslankaprv merged commit a01969f into redpanda-data:dev Jan 29, 2024
16 of 21 checks passed
@mmaslankaprv mmaslankaprv deleted the vlog-pm branch January 29, 2024 06:47
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v23.2.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-16304-v23.2.x-196 remotes/upstream/v23.2.x
git cherry-pick -x d0ee2f864f61042bbf71ce9ef85bf1213f794044 92228fba9427a2cabbf1d1d6c0a10edfefe0ef21

Workflow run logs.

This was referenced Jan 29, 2024
Merged
Open
@mmaslankaprv mmaslankaprv mentioned this pull request Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ztlpn ztlpn ztlpn approved these changes

@dotnwat dotnwat Awaiting requested review from dotnwat

@bharathv bharathv Awaiting requested review from bharathv

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmaslankaprv @vbotbuildovich @ztlpn