Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDT: fix rpk tune list test in GCP. #16353

Merged
merged 1 commit into from
Jan 30, 2024
Merged

CDT: fix rpk tune list test in GCP. #16353

merged 1 commit into from
Jan 30, 2024

Conversation

r-vasquez
Copy link
Contributor

@r-vasquez r-vasquez commented Jan 29, 2024 •
edited

The test failure root cause is that the env CDT_CLOUD_PROVIDER is no longer present in the image that runs the CDT tests and this was used to determine an expected output.

This PR introduces a better and more future-proof method of getting the provider.

Work in progress, I'll update once it's done.

Fixes #15215

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

@r-vasquez
Copy link
Contributor Author

/cdt
provider=gcp
tests/rptest/tests/rpk_tuner_test.py::RpkTunerTest.test_tune_list

@vbotbuildovich
Copy link
Collaborator

'cdt_instance_type' and 'region' is required if 'provider' is not 'aws'

Workflow run logs.

@r-vasquez r-vasquez force-pushed the fix-cdt-tune branch 3 times, most recently from c723a88 to 735380d Compare January 30, 2024 04:12
@r-vasquez
Copy link
Contributor Author

/cdt
provider=gcp
region=us-west2
rp_version=latest
cdt_instance_type=n1-standard-8
tests/rptest/tests/rpk_tuner_test.py::RpkTunerTest.test_tune_list

@vbotbuildovich
Copy link
Collaborator

Invalid input. When rp_repo=ci, the rp_version should be: build or pr

Workflow run logs.

@r-vasquez
Copy link
Contributor Author

/cdt
provider=gcp
region=us-west2
rp_version=build
cdt_instance_type=n1-standard-8
tests/rptest/tests/rpk_tuner_test.py::RpkTunerTest.test_tune_list

@r-vasquez
test: fix rpk tuner list test in GCP
ee2a316 
The CDT_CLOUD_PROVIDER variable is no longer
present in the image so we must get the cloud
provider using another method.
@r-vasquez
Copy link
Contributor Author

/cdt
provider=gcp
region=us-west2
rp_version=build
cdt_instance_type=n1-standard-8
tests/rptest/tests/rpk_tuner_test.py::RpkTunerTest.test_tune_list

@r-vasquez r-vasquez marked this pull request as ready for review January 30, 2024 11:04
@vbotbuildovich
Copy link
Collaborator

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/44476#018d5a4a-d215-49a2-a4bf-d7ba45e0cd6b

@r-vasquez
Copy link
Contributor Author

Successful CDT job in https://buildkite.com/redpanda/redpanda/builds/44470#018d58f6-ab7f-48b4-9cbf-505fffd42086

@r-vasquez r-vasquez merged commit 03539af into redpanda-data:dev Jan 30, 2024
19 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.1.x

This was referenced Jan 30, 2024
Closed
Closed
Merged
Merged
Closed
Merged
@r-vasquez r-vasquez deleted the fix-cdt-tune branch February 1, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twmb twmb twmb approved these changes

@gene-redpanda gene-redpanda Awaiting requested review from gene-redpanda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI Failure (AssertionError) in RpkTunerTest.test_tune_list
3 participants
@r-vasquez @vbotbuildovich @twmb