Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/kvstore: remove oversized alloc #16381

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

rockwotj
Copy link
Contributor

@rockwotj rockwotj commented Jan 31, 2024

It's possible to have enough entries in the kvstore that we run into
oversized allocs. Prevent that by using a btree_map

This was previously discussed in #10340

Fixes: #16320

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

Bug Fixes

  • Prevent oversized allocation with large amounts of controller metadata

It's possible to have enough entries in the kvstore that we run into
oversized allocs. Prevent that by using a btree_map

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@rockwotj rockwotj requested review from bharathv, ztlpn, mmaslankaprv, a team and travisdowns and removed request for a team January 31, 2024 03:23
Copy link
Contributor

@ballard26 ballard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbotbuildovich
Copy link
Collaborator

@rockwotj rockwotj merged commit 1a0afce into redpanda-data:dev Jan 31, 2024
18 of 21 checks passed
@rockwotj rockwotj deleted the kvstore-alloc branch January 31, 2024 15:02
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Failure (OversizedAlloc) in LargeControllerSnapshotTest.test_join_restart
4 participants