cloud_storage_clients/client_pool: handle broken _self_config_barrier #16385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_self_config_barrier is a semaphore used as a barrier for the self config step. at shutdown_connections/stop it's broken (like it's done for _cvar the condition_variable), so it's not useful to bubble up the broken_named_semaphore exception. the code after this will convert it to a gate_closed_exception
these silence broken_named_semaphore generated by client_pool::acquire. since this exception is handled locally there, they are not needed anymore
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/44520#018d6019-ac0a-4eb7-a49e-f63ebcac8282 |
Lazin
approved these changes
Jan 31, 2024
|
/backport v23.3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_self_config_barrier is a semaphore used as a barrier for the self config step.
at shutdown_connections/stop it's broken (like it's done for _cvar the condition_variable), so it's not useful to bubble up the broken_named_semaphore exception.
the code after this will convert it to a gate_closed_exception
see https://github.com/redpanda-data/redpanda/pull/12632/files#r1293657997
This removes some failures from #15150
happening because this ERROR line appearing in the log
Backports Required
Release Notes