[v23.3.x] kafka/client: Fix for stall during client shutdown #16392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- During one of the audit log tests it was observed that the broker did not shutdown. - The logs demonstrated that producer::stop() had run to completion but audit_log_manager::audit_client::shutdown() had not. The only explaination would be the _gate within the audit_client holding up shutdown, and that gate is only used on invoke to client::produce(). This means data is left in the buffer and producer::send() was never called, which resolves outstanding promises. - The kafka client waits to drain all data before shutdown, it does this by calling produce_partition::stop() however this contains a conditional that actually does nothing in the case _in_flight is true. This member variable ensures only one call to send() can occur at a time. If stop() does not drain the buffer then there will be leftover records to produce and since stop() also cancels the producers timer, the records will never be sent and the program will deadlock waiting for futures to resolve that will never occur. - The fix is to ensure that before stop() is called, _in_flight is false. That way stop() will actually drain the buffers. - Fixes: redpanda-data#16198 (cherry picked from commit e688c67)
graphcareful
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #16315
Fixes: #16391,