kafka: Wrap call to lexical_cast in try block #16399
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incremental_alter_configs requests were killing connections when requests supplied an invalid string as a compression_type argument.
The method lexical_cast invokes to convert a compression to a string contains a string_switch method without a default clause, this throws when no matches are found. The solution is to wrap the call to lexical_cast in a try/catch clause.
Fixes: Incremental Alter Config operation kills connection #16281
Backports Required
Release Notes
Bug Fixes