rpk: add cpu_profile to rpk debug bundle
#16414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To modify defaults in our Admin API client. This can be easily expanded to support modifying: - MaxRetries - Backooff Function - LogHook Function. In the future.
r-vasquez
force-pushed
the
rpk_cpu_profiler_2
branch
from
677210e
to
5be5800
Compare
7 tasks
|
new failures in https://buildkite.com/redpanda/redpanda/builds/44564#018d6267-ca50-4e98-99b2-64d5cf4d229e: new failures in https://buildkite.com/redpanda/redpanda/builds/44564#018d6279-eb74-47e3-bc2f-f9daf6de91eb: |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/44564#018d6267-ca50-4e98-99b2-64d5cf4d229e ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/44564#018d6267-ca53-45e3-aa0d-0a15ded6ae7a |
gene-redpanda
previously approved these changes
Feb 1, 2024
r-vasquez
force-pushed
the
rpk_cpu_profiler_2
branch
2 times, most recently
from
b93d25b
to
ab7747c
Compare
twmb
reviewed
Feb 1, 2024
twmb
reviewed
Feb 1, 2024
| @@ -186,3 +193,10 @@ func (a *AdminAPI) DebugPartition(ctx context.Context, namespace, topic string, | |||
| var response DebugPartition | |||
| return response, a.sendAny(ctx, http.MethodGet, fmt.Sprintf("/v1/debug/partition/%v/%v/%v", namespace, topic, partitionID), nil, &response) | |||
| } | |||
|
|
|||
| // RawCPUProfile returns the raw response of the CPU profiler. | |||
| func (a *AdminAPI) RawCPUProfile(ctx context.Context, wait time.Duration) ([]byte, error) { | |||
There was a problem hiding this comment.
+1 for this PR
Maybe if we do Raw a lot, we can just introduce a
func (*AdminAPI) RawRequest(ctx context.Context, pathfmt string, pathargs ...interface{})or some other similar API
This commit add the CPU profile to every debug bundle with a default 30ms of wait sample.
r-vasquez
force-pushed
the
rpk_cpu_profiler_2
branch
from
ab7747c
to
43360ab
Compare
twmb
approved these changes
Feb 2, 2024
gene-redpanda
approved these changes
Feb 2, 2024
|
@r-vasquez we should update the diag bundle docs to show this in the payload. Thnx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the raw response of the CPU profile admin endpoint to the bundle generated by
rpk debug bundle.It introduces a new flag:
--cpu-profiler-waitwith a default of30s, which sets the internalwait_msof the Admin API'sGET /v1/debug/cpu_profileFile Location:
bundle/admin/cpu_profile_<node_address>.jsonFixes #13175
Backports Required
Release Notes
Features
rpk debug bundlenow includes a CPU profile of the requested nodes.