Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slash-cmd: fix /backport command #16427

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

gousteris
Copy link
Contributor

--jq arg of gh graphql returns multiline string in case of multiple fixing issues. Fixing by joining the results in a single line string

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

`--jq` arg of gh graphql returns multiline string in case of multiple
fixing issues. Fixing by joining the results in a single line string
@gousteris gousteris requested a review from a team as a code owner February 1, 2024 14:16
@gousteris gousteris requested review from andrewhsu and removed request for a team February 1, 2024 14:16
@gousteris gousteris self-assigned this Feb 1, 2024
Copy link
Member

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@savex savex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor Author

@gousteris gousteris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ducktape tests are unrelated with this change. I'll merge

@gousteris gousteris merged commit 08d267f into redpanda-data:dev Feb 1, 2024
14 of 17 checks passed
@r-vasquez
Copy link
Contributor

@gousteris I'll backport to v23.3.X since I just encountered this error here: https://github.com/redpanda-data/redpanda/actions/runs/8084586393/job/22093771069?pr=16777

@r-vasquez
Copy link
Contributor

/backport v23.3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants