[v23.3.x] Fixed large allocation in kafka::wait_for_leaders
#16432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we used a simple `std::vector` of futures to make waiting for partition leaders concurrent. Using a vector has a drawback when dealing with large number of topics and partitions since it may be required to allocate large contiguous chunk of memory for a future vector. In this particular case we may not use a fragmented vector or chunked fifo as the `when_all` uses a plain vector internally. To make sure no large chunk of memory is allocated to wait for the partition leaders changed the logic to use `seastar::max_concurrent_for_each`. Fixes: redpanda-data#15908 Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 8d0b584)
Sometimes it may happen that producer swarm is stopped after topic is recreated leading to a test failure. Added check restarting the producer if necessary Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit a18fdcd)
piyushredpanda
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #16287
Fixes: #16430, Fixes: #16431,