Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/config_store_test: unit test for property::operator= + watchers #16443

Merged

Conversation

andijcr
Copy link
Contributor

@andijcr andijcr commented Feb 2, 2024

this tests ensures that operator= does not carry over watchers from the parameters. this behaviour is used when validating an incoming property

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

ztlpn
ztlpn previously approved these changes Feb 2, 2024
@andijcr andijcr marked this pull request as ready for review February 2, 2024 13:16
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Feb 2, 2024

this tests ensures that operator= does not carry over watchers from the
parameters. this behaviour is used when validating an incoming property
@andijcr andijcr force-pushed the feat/config_store_test_prop_bind branch from 9a4edf4 to 90edf7b Compare February 2, 2024 22:20
@andijcr andijcr requested a review from ztlpn February 5, 2024 15:55
@andijcr
Copy link
Contributor Author

andijcr commented Feb 5, 2024

force push: fixed a missing == (thanks implicit conversions to bool!)

@andijcr andijcr merged commit b73d957 into redpanda-data:dev Feb 5, 2024
17 checks passed
@andijcr andijcr deleted the feat/config_store_test_prop_bind branch February 5, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants