[v23.3.x] Return accurate partition count and replication factor in CreateTopics response #16452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically we noticed that cleanup.policy was populated with a stringified int in CreateTopics results. We implement formatters for several topic config types, so we should use them. Using e.g. "delete" for the cleanup policy value (rather than "1") matches the behavior of Apache Kafka. Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit 59b43d3)
To amend create_topics responses with the partition count and replication factor of the created (or already existing) topic. Values pulled from metadata cache (similar to append_topic_configs) Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit bf6763d)
- If the topic already exists, use that return code (36) - If the topic does not exist, return the partition count and replication factor from the request. - Responses now match Apache Kafka (cherry picked from commit b48d3ac)
Adapter for raw_create_topics that takes a list of client-supplied dicts, packs them up in raw requests, and issues a create request. Loads the result into a dict, extracts 'Topics' field, and returns the result (or empty list if something went wrong). Also adds a validate_only bool param to raw_create_topics Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit 4d7a466)
Test for correct config serialization and treatment of specific and defaulted partition count and replication factor values in responses. Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit dad47cb)
In `CreateTopicsResponseTest`. (cherry picked from commit 0654662)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #16410
Fixes: #16450, Fixes: #16451,