rptest: tolerate missing topic metrics after start #16472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andijcr
reviewed
Feb 5, 2024
| @@ -69,7 +69,6 @@ def fully_replicated(self, nodes): | |||
| metric = self.redpanda.metrics_sample("under_replicated_replicas", | |||
| nodes) | |||
| metric = metric.label_filter(dict(namespace="kafka", topic=self.topic)) | |||
| assert len(metric.samples) == len(nodes) | |||
| return all(map(lambda s: s.value == 0, metric.samples)) | |||
There was a problem hiding this comment.
technically all([]) is True,
since fully_replicated is called inside wait_until, maybe it should be
Suggested change
| return all(map(lambda s: s.value == 0, metric.samples)) | |
| if len(metric.samples) != len(nodes): | |
| return False |
There was a problem hiding this comment.
Thanks for catching this. I have updated the method and believe it catches all edge cases in a generic way now.
|
maybe for correctness we should have a wait_until for all the nodes (or at least one) to produce the metric |
During the recovery test in `test_prefix_truncate_recovery`, a node is restarted, and metrics are queried to wait until no partitions are under-replicated. The test occasionally fails at `assert len(metric.samples) == len(nodes)` due to a missing metric for the test topic on the just-restarted node. The redpanda server allows metrics to be queried very early in the server startup flow but the controller log which instructs the server which partition topics it manages is applied asynchronously. To resolve this issue, we remove the assertion and instead rely on the fact that other servers will correctly report under-replicated partitions using `all(map(lambda s: s.value == 0, metric.samples))`. Thus, the assert statement is both incorrect and redundant. An extra check is added to ensure that metrics for all partitions under test are present and the expression is evaluated for all of them. This could happen due to a bug or all nodes containing replicas being restarted and not producing metrics yet. A situation unlikely to happen in this test but makes the `fully_replicated` method more general and future proof. Fixes redpanda-data#16115
nvartolomei
force-pushed
the
nv/test_prefix_truncate_recovery
branch
from
f0b83dc
to
586584f
Compare
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/44806#018d837b-9274-4511-bd72-57ca4ec5a60e |
|
/backport v23.3.x |
This was referenced Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the recovery test in
test_prefix_truncate_recovery, a node is restarted, and metrics are queried to wait until no partitions are under-replicated.The test occasionally fails at
assert len(metric.samples) == len(nodes)due to a missing metric for the test topic on the just-restarted node.The redpanda server allows metrics to be queried very early in the server startup flow but the controller log which instructs the server which partition topics it manages is applied asynchronously.
To resolve this issue, we remove the assertion and instead rely on the fact that other servers will correctly report under-replicated partitions using
all(map(lambda s: s.value == 0, metric.samples)).Thus, the assert statement is both incorrect and redundant.
Fixes #16115
Backports Required
Release Notes