Improved handling of truncation with ACKS=1 #16475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaslankaprv
force-pushed
the
raft-acks-1-improvements
branch
from
71b489c
to
46c5f29
Compare
|
/dt |
bharathv
reviewed
Feb 5, 2024
| @@ -2013,7 +2013,7 @@ consensus::do_append_entries(append_entries_request&& r) { | |||
|
|
|||
| // section 3 | |||
| if (request_metadata.prev_log_index < last_log_offset) { | |||
| if (unlikely(request_metadata.prev_log_index < _commit_index)) { | |||
| if (unlikely(request_metadata.prev_log_index < last_visible_index())) { | |||
There was a problem hiding this comment.
so IIUC the problem is with follower fetching + acks=1 because, on a follower the log can be truncated below high watermark (because of committed offset check) say during recovery and the subsequent read from the follower may result in an out of range read, is that correct?
mmaslankaprv
force-pushed
the
raft-acks-1-improvements
branch
from
46c5f29
to
681fbb5
Compare
ztlpn
reviewed
Feb 6, 2024
| @@ -2013,7 +2013,7 @@ consensus::do_append_entries(append_entries_request&& r) { | |||
|
|
|||
| // section 3 | |||
| if (request_metadata.prev_log_index < last_log_offset) { | |||
| if (unlikely(request_metadata.prev_log_index < _commit_index)) { | |||
| if (unlikely(request_metadata.prev_log_index < last_visible_index())) { | |||
There was a problem hiding this comment.
Should we use last_visible_index() in line 2020 as well? (not entirely understanding its significance, but seems logical...)
There was a problem hiding this comment.
makes sense, i will change this
Signed-off-by: Michal Maslanka <michal@redpanda.com>
If an offset was already visible a follower must not be allowed to truncate it as it may lead to a situation in which an offset is visible and not readable. Visible batches has the same replication guarantees as committed batches as leader still waits for the majority to acknowledge message at given offset before making it visible to the readers. This makes it possible not to truncate offsets which were previously visible. Signed-off-by: Michal Maslanka <michal@redpanda.com>
Added test checking if an offset that is visible on the leader is not truncated on the followers. Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
raft-acks-1-improvements
branch
from
681fbb5
to
8975291
Compare
ztlpn
approved these changes
Feb 7, 2024
|
/backport v23.3.x |
|
/backport v23.2.x |
|
Failed to create a backport PR to v23.2.x branch. I tried: |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an offset was already visible a follower must not be allowed to
truncate it as it may lead to a situation in which an offset is visible
and not readable.
Visible batches has the same replication guarantees as committed batches
as leader still waits for the majority to acknowledge message at given
offset before making it visible to the readers. This makes it possible
not to truncate offsets which were previously visible.
Backports Required
Release Notes
Improvements