Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: disable snapshots when testing partial controller deletion #16495

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

mmaslankaprv
Copy link
Member

@mmaslankaprv mmaslankaprv commented Feb 6, 2024

When testing partial deletion the test selects a segment to remove from controller log. Before deleting the segment but after it was selected it may be accounted in the controller snapshot.

Disabled controller snapshot to prevent the test racing with snapshot creation.

Fixes: #8217

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

When testing partial deletion the test selects a segment to remove from
controller log. Before deleting the segment but after it was selected it
may be accounted in the controller snapshot.

Disabled controller snapshot to prevent the test racing with
snapshot creation.

Fixes: redpanda-data#8217

Signed-off-by: Michal Maslanka <michal@redpanda.com>
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Feb 6, 2024

new failures in https://buildkite.com/redpanda/redpanda/builds/44749#018d7e9c-0051-4ada-8218-f5a84f3b5e8c:

"rptest.tests.topic_creation_test.TopicRecreateTest.test_topic_recreation_while_producing.workload=IDEMPOTENT.cleanup_policy=compact"

new failures in https://buildkite.com/redpanda/redpanda/builds/44749#018d7e9c-0056-4ac9-9508-6b8c5d7dafa7:

"rptest.tests.topic_creation_test.TopicRecreateTest.test_topic_recreation_while_producing.workload=IDEMPOTENT.cleanup_policy=delete"

@mmaslankaprv
Copy link
Member Author

/ci-repeat 1

@vbotbuildovich
Copy link
Collaborator

@piyushredpanda piyushredpanda merged commit b4480a5 into redpanda-data:dev Feb 9, 2024
18 of 20 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@ztlpn
Copy link
Contributor

ztlpn commented May 16, 2024

/backport v23.2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Failure (search victim assert) in ControllerEraseTest.test_erase_controller_log
4 participants