Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing comma in kubectl.py #16506

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Fix missing comma in kubectl.py #16506

merged 1 commit into from
Feb 6, 2024

Conversation

StephanDollberg
Copy link
Member

@StephanDollberg StephanDollberg commented Feb 6, 2024 •
edited

Follow on to PR #16505

Fix missing comma. The code "works" because the strings get just appended to each
other but then form an invalid cli arg.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

@StephanDollberg
tests: Fix missing comma in kubectl
31e8543 
Code runs anyway as the strings will just be appended
andrewhsu
andrewhsu approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piyushredpanda piyushredpanda merged commit 0afd0bd into dev Feb 6, 2024
14 of 19 checks passed
@piyushredpanda piyushredpanda deleted the stephan/fix-kube-py branch February 6, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewhsu andrewhsu andrewhsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StephanDollberg @andrewhsu @piyushredpanda