rpc: Add config flag to enable/disable compression for replies #16525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a flag to allow disabling internal rpc reply compression. Right now we unconditionally enable compression for rpc replies if they are above the min compression size (1Kib). In this commit we don't change the default and keep compression on but we might change that in a follow up commit as the cpu overhead from compressing/uncompressing larger messages has shown to be detrimental to overall performance.
mmaslankaprv
approved these changes
Feb 8, 2024
|
/backport v23.3.x |
|
/backport v23.2.x |
|
Failed to create a backport PR to v23.2.x branch. I tried: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flag to allow disabling internal rpc reply compression.
Right now we unconditionally enable compression for rpc replies if they
are above the min compression size (1Kib).
In this commit we don't change the default and keep compression on but
we might change that in a follow up commit as the cpu overhead from
compressing/uncompressing larger messages has shown to be detrimental to
overall performance.
Backports Required
Release Notes