Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.2.x] Improved handling of truncation with ACKS=1 #16530

Merged
merged 2 commits into from
Feb 7, 2024
Merged

[v23.2.x] Improved handling of truncation with ACKS=1 #16530

merged 2 commits into from
Feb 7, 2024

Commits on Feb 7, 2024

  1. r/consensus: log visible offsets when truncating log 

    Signed-off-by: Michal Maslanka <michal@redpanda.com>
(cherry picked from commit ec7b6ed)
    @mmaslankaprv
    mmaslankaprv committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    9ceca9e View commit details
    Browse the repository at this point in the history

  2. r/consensus: do not allow follower to truncate log that is consumable 

    If an offset was already visible a follower must not be allowed to
truncate it as it may lead to a situation in which an offset is visible
and not readable.

Visible batches has the same replication guarantees as committed batches
as leader still waits for the majority to acknowledge message at given
offset before making it visible to the readers. This makes it possible
not to truncate offsets which were previously visible.

Signed-off-by: Michal Maslanka <michal@redpanda.com>
(cherry picked from commit 3d9a794)
    @mmaslankaprv
    mmaslankaprv committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    1645940 View commit details
    Browse the repository at this point in the history