Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rptest: force cleaning of teleport data dir #16542

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

andrewhsu
Copy link
Member

@andrewhsu andrewhsu commented Feb 8, 2024

following on PR #16359, this PR fixes error in running ducktape tests on cloudv2:

...
  File "/home/ubuntu/redpanda/tests/rptest/clients/kubectl.py", line 271, in _setup_tbot
    shutil.rmtree(self.TELEPORT_DATA_DIR)
  File "/usr/lib/python3.10/shutil.py", line 715, in rmtree
    onerror(os.lstat, path, sys.exc_info())
  File "/usr/lib/python3.10/shutil.py", line 713, in rmtree
    orig_st = os.lstat(path)
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tbot-data'

by forcing deletion of the teleport data dir.

i validated this by running test without /tmp/tbot-data dir to simulate buildkite's scheduled job scenario:

ducktape \
  --debug \
  --globals=/home/ubuntu/redpanda/tests/globals.json \
  --cluster=ducktape.cluster.json.JsonCluster \
  --cluster-file=/home/ubuntu/redpanda/tests/cluster.json \
  tests/rptest/tests/services_self_test.py::SimpleSelfTest.test_cloud

output:

test_id:    rptest.tests.services_self_test.SimpleSelfTest.test_cloud
status:     PASS
run time:   54.107 seconds
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
========================================================================================================================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.8.18
session_id:       2024-02-08--006
run time:         54.125 seconds
tests run:        1
passed:           1
flaky:            0
failed:           0
ignored:          0
opassed:          0
ofailed:          0
========================================================================================================================================================================================

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

@andrewhsu andrewhsu self-assigned this Feb 8, 2024
@andrewhsu
Copy link
Member Author

this pr is ready for review. i have example of successful test run in description. no need to wait for other tests in PR check to run to completion.

Copy link
Contributor

@savex savex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Feb 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants