Use confirmed term as a source of leader epoch #16560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A confirmed term is used to determine if the state of a replica is up to date after the leader election. Only after the confirmed term is equal to the current term one can reason about the Raft group state. On the leader the confirmed term is updated after first successful replication of a batch subsequent to a leader election. After the replication succeed leader is guaranteed to have up to date committed and visible offsets. On the follower the confirmed term is updated only when an append entries request from the current leader may be accepted and follower may return success. Signed-off-by: Michal Maslanka <michal@redpanda.com>
A leader epoch is used by Kafka clients to determine if a replica is up to date with the leader and to detect truncation. The leader epoch differs from Raft term as the term is updated when leader election starts. Whereas the leader epoch is updated after the state of the replica is determined. Therefore the leader epoch uses confirmed term instead of the simple term which is incremented every time the leader election starts. Signed-off-by: Michal Maslanka <michal@redpanda.com>
|
new failures in https://buildkite.com/redpanda/redpanda/builds/44940#018d8dc3-d067-4a62-a6ec-067850966942: |
ztlpn
approved these changes
Feb 9, 2024
|
failure is #16540 |
|
/backport v23.3.x |
|
/backport v23.2.x |
|
Failed to create a backport PR to v23.2.x branch. I tried: |
This was referenced Feb 11, 2024
dotnwat
reviewed
Feb 27, 2024
mmaslankaprv
added a commit
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A leader epoch is used by Kafka clients to determine if a replica is up
to date with the leader and to detect truncation.
The leader epoch differs from Raft term as the term is updated when
leader election starts. Whereas the leader epoch is updated after the
state of the replica is determined. Therefore the leader epoch uses
confirmed term instead of the simple term which is incremented every
time the leader election starts.
Backports Required
Release Notes
Bug Fixes