Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xform/service: Remove exception handling from _log_manager->start #16571

Merged
merged 1 commit into from
Feb 10, 2024
Merged

xform/service: Remove exception handling from _log_manager->start #16571

merged 1 commit into from
Feb 10, 2024

Conversation

oleiman
Copy link
Member

@oleiman oleiman commented Feb 10, 2024 •
edited

The previous handling was incorrect (awaiting on an invalid future),
this probably shouldn't fail silently, and everything in logging::manager::start
is noexcept anyway.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

@oleiman oleiman self-assigned this Feb 10, 2024
@github-actions github-actions bot added area/redpanda area/wasm WASM Data Transforms labels Feb 10, 2024
@oleiman oleiman marked this pull request as draft February 10, 2024 02:02
@oleiman
xform/service: Remove exception handling from _log_manager->start
84dac04 
The previous handling was incorrect (awaiting on an invalid future),
this probably shouldn't fail silently, and everything in logging::manager::start
is noexcept anyway.

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
@oleiman oleiman force-pushed the xfm-logging/await-invalid-fut_ branch from 934719c to 84dac04 Compare February 10, 2024 02:10
@oleiman oleiman marked this pull request as ready for review February 10, 2024 02:11
@oleiman oleiman changed the title xform/service: Don't co_await an invalid future xform/service: Remove exception handling from _log_manager->start Feb 10, 2024
@oleiman oleiman merged commit 99acfc1 into redpanda-data:dev Feb 10, 2024
19 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v23.3.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-16571-v23.3.x-16 remotes/upstream/v23.3.x
git cherry-pick -x 84dac04e55f35f0c8f615be1823405f32c2bd804

Workflow run logs.

@vbotbuildovich vbotbuildovich mentioned this pull request Feb 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockwotj rockwotj rockwotj approved these changes

@dotnwat dotnwat Awaiting requested review from dotnwat

Assignees

@oleiman oleiman

Labels
area/redpanda area/wasm WASM Data Transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oleiman @vbotbuildovich @rockwotj