Set KAFKA_OPTS to empty in OMB #16577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set KAFKA_OPTS to a single space in OMB, which is required to use newer OMB versions as otherwise we try to use a -javaagent from a location that doesn't exist in DT OMB setup (see bin/benchmark-workers script). Single empty space is because a totally empty KAFKA_OPTS will still be overridden by the bin/benchmark-workers script. Issue redpanda-data/core-internal#1016.
travisdowns
commented
Feb 12, 2024
| --stats-port {OpenMessagingBenchmarkWorkers.STATS_PORT} \ | ||
| >> {OpenMessagingBenchmarkWorkers.STDOUT_STDERR_CAPTURE} 2>&1 & disown" | ||
| start_cmd = ( | ||
| f"cd /opt/openmessaging-benchmark; " |
There was a problem hiding this comment.
also changed this to use this other apparently more pythonic pattern for multi-line strings, because all the intendation space was actually ending up in the command (hard to read in the logfile).
travisdowns
commented
Feb 12, 2024
| start_cmd = ( | ||
| f"cd /opt/openmessaging-benchmark; " | ||
| f"HEAP_OPTS=\" \" " | ||
| f"KAFKA_OPTS=\" \" " |
There was a problem hiding this comment.
This 1 line is actual material change. The redpanda main OMB branch has KAFKA_OPTS use now, so once we update the SHA this will break, fixing this preemptively.
StephanDollberg
approved these changes
Feb 13, 2024
|
/ci-repeat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set KAFKA_OPTS to a single space in OMB, which is required to use newer OMB versions as otherwise we try to use a -javaagent from a location that doesn't exist in DT OMB setup (see
bin/benchmark-workers script).
Single empty space is because a totally empty KAFKA_OPTS will still be overridden by the bin/benchmark-workers script.
Issue redpanda-data/core-internal#1016.
Backports Required
Release Notes