Added timeout to gtest_raft_rpunit
#16637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/dt |
rockwotj
reviewed
Feb 19, 2024
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45124#018dc21f-bbec-4a3f-a6bf-0a8c1e2591f0 |
Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
raft-rpunit-test
branch
from
7c69966
to
50b4382
Compare
Added timeout to the test to prevent it from hanging and to be able to retrieve the logs from the test that execution stuck. Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
raft-rpunit-test
branch
from
50b4382
to
2e2c8b7
Compare
mmaslankaprv
changed the title
gtest_raft_rpunit
bharathv
approved these changes
Feb 20, 2024
dotnwat
reviewed
Feb 23, 2024
| @@ -173,4 +175,7 @@ class seastar_test : public ::testing::Test { | |||
| #define ASSERT_LT_CORO(val1, val2) GTEST_ASSERT_LT_CORO(val1, val2) | |||
| #define ASSERT_LE_CORO(val1, val2) GTEST_ASSERT_LE_CORO(val1, val2) | |||
| #define ASSERT_NE_CORO(val1, val2) GTEST_ASSERT_NE_CORO(val1, val2) | |||
|
|
|||
| #define GTEST_SKIP_CORO() GTEST_SKIP_CORO_("") | |||
|
|
|||
There was a problem hiding this comment.
This macro appears to be unused in this PR. It also should have a test in test_utils/tests/gtest_tests.cc.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added timeout to for the
gtest_raft_rpunit. This will allow us to retrieve logs from failed test.Backports Required
Release Notes