cloud_storage: skip over segments below archive start #16645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as draft while I sort out a test failure |
I have an upcoming test that depends on segments actually being deleted in S3. The current s3_imposter implementation only removes objects if using the singular object deletion API. This commit fills in the implementation for batch deletion to actually remove the batch-deleted files from the list maintained by s3_imposter.
An upcoming change will examine the full log's start offset to determine whether or not to skip over a given segment. To that end, this introduces a method similar to `full_log_start_kafka_offset` that instead returns the model::offset corresponding to the log's start offset.
andrwng
force-pushed
the
timequery-archival-gc-bug
branch
from
4d022c9
to
3a03e05
Compare
|
/ci-repeat |
This fixes a bug for timequeries that could result in a removed segment being unsuccessfully downloaded during a timequery. The sequence of events is as follows: 1. Spillover manifest [7278, 8592] 2. Spillover more manifests... [...13574] 3. Eventually our stm manifest is [13875, 15802] 4. We housekeep and truncate to 7804. This is the new archive start offset and archive clean offset 5. A timequery comes in whose timestamp falls in manifest [7278, 8592] 6. Segment [7278-7410] is attempted to be downloaded, which has already been removed To fix this, as we're seeking within a given manifest, we'll now check against the overall start offset of the partition, skipping any segments that fall below the start. Fixes redpanda-data#15042
andrwng
force-pushed
the
timequery-archival-gc-bug
branch
from
3a03e05
to
d056080
Compare
|
/ci-repeat |
andijcr
approved these changes
Feb 21, 2024
Lazin
approved these changes
Feb 21, 2024
|
/backport v23.3.x |
|
/backport v23.2.x |
|
Failed to create a backport PR to v23.2.x branch. I tried: |
This was referenced Feb 21, 2024
|
Thanks for the fix, @andrwng ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug for timequeries that could result in a removed segment being
unsuccessfully downloaded during a timequery. The sequence of events is as
follows:
To fix this, as we're seeking within a given manifest, we'll now check against
the overall start offset of the partition, skipping any segments that fall
below the start.
Fixes #15042
Backports Required
Release Notes
Bug fix