Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rptest: remove config_file credential source support #16646

Merged
merged 1 commit into from
Feb 21, 2024
Merged

rptest: remove config_file credential source support #16646

merged 1 commit into from
Feb 21, 2024

Conversation

nvartolomei
Copy link
Contributor

Doesn't seem to be used anywhere and just creates confusion.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

@nvartolomei
rptest: remove config_file credential source support
4572b81 
Doesn't seem to be used anywhere and just creates confusion.
ivotron
ivotron reviewed Feb 20, 2024
View reviewed changes
Copy link
Member

@ivotron ivotron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might affect CDT schedules, so probably good to run /cdt before merging. If those go green (in addition to compose ducktape), then it LGTM

@nvartolomei
Copy link
Contributor Author

/cdt
tests/rptest/tests/archival_test.py

@nvartolomei
Copy link
Contributor Author

/cdt
provider=gcp
region=us-west2
cdt_instance_type=n2-highmem-4
tests/rptest/tests/archival_test.py

@nvartolomei
Copy link
Contributor Author

@ivotron happy with it?

@ivotron
Copy link
Member

ivotron commented Feb 20, 2024

@ivotron happy with it?

yeah, flawless runs 🚀

@nvartolomei nvartolomei merged commit f17318f into redpanda-data:dev Feb 21, 2024
18 checks passed
@dotnwat
Copy link
Member

dotnwat commented Feb 22, 2024

This is the one that we might revert @nvartolomei ?

nvartolomei added a commit to nvartolomei/redpanda that referenced this pull request Feb 22, 2024
@nvartolomei
Revert "Merge pull request redpanda-data#16646 from nvartolomei/nv/nu…
9d6ae30 
…ke-config-file"

This reverts commit f17318f, reversing
changes made to 82e1270.
@nvartolomei
Copy link
Contributor Author

@dotnwat yes, #16674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivotron ivotron ivotron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nvartolomei @ivotron @dotnwat