serde: Add node_health_report ser/de benchmark #16656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanDollberg
force-pushed
the
stephan/serde-bench
branch
from
6f412ac
to
e825bcb
Compare
7 tasks
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45238#018dd115-73b7-4a58-89de-249f79c78cd0 |
travisdowns
reviewed
Feb 22, 2024
src/v/serde/test/bench.cc
Outdated
| return hr; | ||
| } | ||
|
|
||
| __attribute__((noinline)) void do_bench_serialize_node_health_report( |
There was a problem hiding this comment.
note: I think [[gnu::noinline]] is preferred today
Adds a benchmark for `node_health_report` de-serialization across the topic and partitions dimensions. | test | iterations | median | mad | min | max | allocs | tasks | inst | | - | - | - | - | - | - | - | - | - | | node_health_report.serialize_many_partitions | 830 | 1.041ms | 536.095ns | 1.040ms | 1.043ms | 66.000 | 0.000 | 23326375.0 | | node_health_report.serialize_many_topics | 211 | 2.823ms | 2.239us | 2.821ms | 2.828ms | 90.000 | 0.000 | 55992429.7 | | node_health_report.deserialize_many_partitions | 365 | 1.490ms | 261.786ns | 1.490ms | 1.491ms | 6258.000 | 0.000 | 42209042.8 | | node_health_report.deserialize_many_topics | 113 | 3.582ms | 2.915us | 3.576ms | 3.586ms | 50398.000 | 0.000 | 84158331.2 |
StephanDollberg
force-pushed
the
stephan/serde-bench
branch
from
e825bcb
to
5fcdb86
Compare
travisdowns
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a benchmark for
node_health_reportde-serialization across thetopic and partitions dimensions.
Backports Required
Release Notes