Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PESDLC-109 rptest: add metrics gathering methods to RedpandaServiceCloud #16668

Merged
merged 11 commits into from
Mar 6, 2024
Merged

PESDLC-109 rptest: add metrics gathering methods to RedpandaServiceCloud #16668

merged 11 commits into from
Mar 6, 2024

Conversation

andrewhsu
Copy link
Member

@andrewhsu andrewhsu commented Feb 21, 2024 •
edited

Fixes https://github.com/redpanda-data/core-internal/issues/993

added metrics gathering methods to RedpandaServiceCloud that complement the metrics gathering methods in RedpandaService:

  • RedpandaServiceCloud.metrics_sample()
  • RedpandaServiceCloud.metrics_samples()
  • RedpandaServiceCloud.metric_sum()

also added simple self tests to verify each of these.

verified with:

ducktape \
  --debug \
  --globals=/home/ubuntu/redpanda/tests/globals.json \
  --cluster=ducktape.cluster.json.JsonCluster \
  --cluster-file=/home/ubuntu/redpanda/tests/cluster.json \
  tests/rptest/redpanda_cloud_tests/cloud_self_test.py::SelfRedpandaCloudTest

output:

test_id:    rptest.redpanda_cloud_tests.cloud_self_test.SelfRedpandaCloudTest.test_metric_sum
status:     PASS
run time:   41.296 seconds
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.redpanda_cloud_tests.cloud_self_test.SelfRedpandaCloudTest.test_metrics_sample
status:     PASS
run time:   37.044 seconds
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.redpanda_cloud_tests.cloud_self_test.SelfRedpandaCloudTest.test_metrics_samples
status:     PASS
run time:   52.362 seconds
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.redpanda_cloud_tests.cloud_self_test.SelfRedpandaCloudTest.test_simple
status:     PASS
run time:   24.468 seconds
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_id:    rptest.redpanda_cloud_tests.cloud_self_test.SelfRedpandaCloudTest.test_healthy
status:     PASS
run time:   38.856 seconds
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
================================================================================================================================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.8.18
session_id:       2024-03-01--007
run time:         3 minutes 14.122 seconds
tests run:        5
passed:           5
flaky:            0
failed:           0
ignored:          0
opassed:          0
ofailed:          0
================================================================================================================================================================================================

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

@andrewhsu andrewhsu marked this pull request as ready for review February 23, 2024 00:45
@andrewhsu
Copy link
Member Author

PR description updated with test result, ready for review

travisdowns
travisdowns previously requested changes Feb 23, 2024
View reviewed changes
tests/rptest/services/redpanda.py Show resolved Hide resolved
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Feb 23, 2024 •
edited

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45269#018dd3c7-648c-4f4f-9f0f-24057fe02b94

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45717#018e1073-8120-413f-a98c-cb6833813293

@andrewhsu
Copy link
Member Author

converting to draft to address review comments

@andrewhsu andrewhsu marked this pull request as draft February 23, 2024 17:36
@andrewhsu andrewhsu force-pushed the metrics-sample branch 4 times, most recently from 250fd48 to c108fca Compare February 29, 2024 21:48
@andrewhsu andrewhsu changed the title rptest: add RedpandaServiceCloud.metrics_sample() rptest: add metrics gathering methods to RedpandaServiceCloud Mar 1, 2024
@andrewhsu andrewhsu marked this pull request as ready for review March 1, 2024 09:05
@andrewhsu
Copy link
Member Author

PR updated and rebased with tip of dev. ready for review.

@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/45538#018df972-1965-4992-8f8a-071f0af2fa94:

"rptest.tests.tiered_storage_model_test.TieredStorageTest.test_tiered_storage.cloud_storage_type=CloudStorageType.ABS.test_case=.TS_Read==True.AdjacentSegmentMergerReupload==True.SpilloverManifestUploaded==True"

@andrewhsu andrewhsu changed the title rptest: add metrics gathering methods to RedpandaServiceCloud PESDLC-109 rptest: add metrics gathering methods to RedpandaServiceCloud Mar 1, 2024
@andrewhsu andrewhsu requested a review from rpdevmp March 1, 2024 19:22
savex
savex reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@savex savex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several type checks and content checks, the rest is good.

tests/rptest/services/redpanda.py Outdated Show resolved Hide resolved
tests/rptest/services/redpanda.py Show resolved Hide resolved
@andrewhsu
Copy link
Member Author

i've added git commit 34a7887 to this PR and re-ran test:

ducktape \
  --debug \
  --globals=/home/ubuntu/redpanda/tests/globals.json \
  --cluster=ducktape.cluster.json.JsonCluster \
  --cluster-file=/home/ubuntu/redpanda/tests/cluster.json \
  tests/rptest/redpanda_cloud_tests/cloud_self_test.py::SelfRedpandaCloudTest.test_metric_sum

output

test_id:    rptest.redpanda_cloud_tests.cloud_self_test.SelfRedpandaCloudTest.test_metric_sum
status:     PASS
run time:   39.434 seconds
--------------------------------------------------------------------------------------------------------------------------------------------
============================================================================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.8.18
session_id:       2024-03-05--003
run time:         39.457 seconds
tests run:        1
passed:           1
flaky:            0
failed:           0
ignored:          0
opassed:          0
ofailed:          0
============================================================================================================================================

ready for review

@andrewhsu andrewhsu requested review from savex and rpdevmp March 5, 2024 20:47
savex
savex approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@savex savex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rpdevmp
rpdevmp reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@rpdevmp rpdevmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu dismissed travisdowns’s stale review March 6, 2024 15:08

dismissing review because i have 2 lgtm, but feel free to let me know if there are followup changes you think i should have for this PR and i'll add them

@andrewhsu andrewhsu merged commit befd76b into redpanda-data:dev Mar 6, 2024
16 checks passed
@andrewhsu andrewhsu deleted the metrics-sample branch March 6, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpdevmp rpdevmp rpdevmp left review comments

@savex savex savex approved these changes

@travisdowns travisdowns Awaiting requested review from travisdowns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andrewhsu @vbotbuildovich @savex @travisdowns @rpdevmp