test: check for non-empty samples from any core #16671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only core 0 was checked for samples in the test. We can see here in the
result of querying the cpu profiler endpoint that only core 1 had
samples.
[DEBUG - 2024-02-16 02:04:02,865 - admin - _request - lineno:383]: Response OK, JSON: [{'shard_id': 0, 'dropped_samples': 0}, {'shard_id': 1, 'dropped_samples': 0, 'samples': [{'user_backtrace': '0xef666 /opt/redpanda_installs/ci/lib/libseastar.so+0x597c482 /opt/r
KeyError('samples')
Traceback (most recent call last):
File "/usr/local/lib/python3.10/dist-packages/ducktape/tests/runner_client.py", line 184, in _do_run
data = self.run_test()
File "/usr/local/lib/python3.10/dist-packages/ducktape/tests/runner_client.py", line 269, in run_test
return self.test_context.function(self.test)
File "/root/tests/rptest/services/cluster.py", line 104, in wrapped
r = f(self, *args, **kwargs)
File "/root/tests/rptest/tests/cpu_profiler_admin_api_test.py", line 73, in test_get_cpu_profile_with_override
profile[0]["samples"]
KeyError: 'samples'
Fixes: redpanda-data#16618
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45217#018dce74-a99b-4086-b6be-b3f81abf6c6a |
travisdowns
approved these changes
Feb 22, 2024
|
Thanks for the quick fix here @dotnwat ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only core 0 was checked for samples in the test. We can see here in the result of querying the cpu profiler endpoint that only core 1 had samples.
Fixes: #16618
Backports Required
Release Notes