[v23.3.x] Implement async_for_each #16682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as std::for_each, but which yields periodically. Written in a style which keeps in inner loop fast, equivalent to the non-async version (optimizer willing, but seems to be true in the case I checked). For the simplest use cases we offer async_for_each, which is the same as std::for_each except that it yields every Traits::Interval iterations: every call starts the "work counter" anew. For more complicated cases, like nested loops, it may be convenient to carry the counter from one iteration to the next, in order to yield at the correct times. For example, in a doubly nested loop where the inner loop always ran for less than Interval iterations, we would not yield with the simple functions. Issue redpanda-data/core-internal#1061. (cherry picked from commit a4c6b64)
(cherry picked from commit e602960)
|
@StephanDollberg straight backport except that I had to change |
StephanDollberg
approved these changes
Feb 22, 2024
This was referenced Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #16662.
Fixes #16673.
Backports Required
Release Notes