Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud-tests: use a time-based calculation of load #16715

Merged

Conversation

travisdowns
Copy link
Member

For HighThroughputTest::test_decomm_and_add we used a fixed value of 10,000 messages to warm up the test, but with 4K messages and high tiers this could result in a warmup time of < 1 second, which rounded to zero, causing the test to time out immediately (in addition to being an unsuitably small warmup even if it didn't time out).

Instead, use a time-based workload calculation, i.e., use the number of messages we expect to be able to produce in a given time period: this will naturally scale with tier size as expected throughput increases.

Fixes #16470.

Backports Required

  • none - not backporting DT
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

For HighThroughputTest::test_decomm_and_add we used a fixed value of
10,000 messages to warm up the test, but with 4K messages and high
tiers this could result in a warmup time of < 1 second, which rounded
to zero, causing the test to time out immediately (in addition to being
an unsuitably small warmup even if it didn't time out).

Instead, use a time-based workload calculation, i.e., use the number
of messages we expect to be able to produce in a given time period:
this will naturally scale with tier size as expected throughput
increases.

Fixes redpanda-data#16470.
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Feb 26, 2024

Copy link
Contributor

@savex savex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@piyushredpanda piyushredpanda merged commit 89731b2 into redpanda-data:dev Feb 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Failure (ZeroDivisionError) in HighThroughputTest.test_decommission_and_add
4 participants