http/client: add post() method helper
#16718
Conversation
The iobuf already exists in memory and can be used directly as the body for the http request. Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
|
/ci-repeat 1 |
|
new failures in https://buildkite.com/redpanda/redpanda/builds/45365#018de81e-602e-4fc2-a322-7c245141bc21: |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45365#018de81e-602b-40dd-8120-40feda2e92e2 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45365#018de82f-ddb5-4d47-b67c-2638951c4b57 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45377#018de8eb-d79f-47ee-b685-15220e91142c ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45386#018de97b-25f5-437a-a451-af02dc8a0ef6 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45386#018de97b-25f1-4b28-a322-1f337fb525c1 |
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
When requests are made without a host header field then one is automatically added using the host/port from the transport config. Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
|
/ci-repeat 1 |
dotnwat
requested review from
Lazin,
abhijat,
mmaslankaprv and
andrwng
and removed request for
Lazin
| http::client::request_header | ||
| metrics_reporter::make_header(const iobuf& buffer) { | ||
| http::client::request_header header; | ||
| header.method(boost::beast::http::verb::post); | ||
| header.target(std::string(_address.path)); | ||
| header.insert( | ||
| boost::beast::http::field::content_length, | ||
| fmt::format("{}", buffer.size_bytes())); | ||
| header.insert( | ||
| boost::beast::http::field::host, | ||
| fmt::format("{}:{}", _address.host, _address.port)); |
There was a problem hiding this comment.
Nice simplification -- glad callers won't have to deal with headers anymore.
|
cc @Lazin can you take a look? |
Adds a
http::client::postmethod which handles preparation of a post request as a convenience for the metrics reporter which is switched over to use this method.Backports Required
Release Notes