tests: refactor consumer group balancing test #16775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor consumer group balancing test to directly validate `__consumer_offsets` partition replicas placement instead of validating consumer groups coordinators. Fixes: redpanda-data#9697 Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
requested review from
bharathv,
ztlpn,
oleiman and
graphcareful
bharathv
approved these changes
Feb 28, 2024
| f"coordinators of groups: {coord_groups}, " | ||
| f"groups: {len(groups)}, brokers: {len(self.redpanda.nodes)}, " | ||
| f"coord_density: {coord_density}, expected_coord_density: {expected_coord_density}" | ||
| for node, replicas in replicas_per_node.items(): |
There was a problem hiding this comment.
We need a waiter for this? I thought the first assignment is 'random' but the balancer eventually balances by domain which is when actual uniformity is achieved.
There was a problem hiding this comment.
this is a data balance so it does it during the first assignment,
|
/ci-repeat 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor consumer group balancing test to directly validate
__consumer_offsetspartition replicas placement instead of validating consumer groups coordinators.Fixes: #9697
Backports Required
Release Notes