RBAC Admin API Swagger and handler stubs #16781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiman
force-pushed
the
rbac/swagger
branch
from
3526a17
to
2c373c7
Compare
|
/dt |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45488#018df3fe-9fde-420b-8ab6-48abd2cde0cb |
BenPope
reviewed
Feb 29, 2024
Superuser only (with the exception of list_user_roles) Each handler returns an error or empty list as approprate for an empty, not yet implemented collection of roles.
oleiman
force-pushed
the
rbac/swagger
branch
from
2c373c7
to
395ea14
Compare
|
force push swagger cleanup |
pgellert
reviewed
Mar 1, 2024
A starting point for building out tests for RBAC extensions API wrappers: - list_user_roles - create_role - get_role (by name) - delete_role (by name) - update_role (takes a RoleUpdate tuple) - list_roles (with optional name prefix and membership filters) - update_role_members - list_role_members Includes some structure for API surface: - RoleErrorCode - RoleError - RoleUpdate - RoleDescription - RolesList
Testing route wiring and superuser-only access.
|
force push to fix janky url param encoding |
oleiman
requested review from
BenPope,
pgellert,
michael-redpanda and
graphcareful
pgellert
approved these changes
Mar 4, 2024
|
@BenPope - any objections? |
BenPope
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces swagger JSON describing Admin API extensions for RBAC.
Includes stub handlers for the new API surface and stub integration tests.
Closes https://github.com/redpanda-data/core-internal/issues/1103
Backports Required
Release Notes