Add support for client_swarm's metrics api to produce_swarm #16796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| int(res["max"])) | ||
|
|
||
| def await_progress(self, target_msg_rate, timeout_sec, err_msg=None): | ||
| time.sleep(0.5) |
There was a problem hiding this comment.
Nice catch, that was an artifact from testing. I've removed it in the latest rev.
ballard26
force-pushed
the
producer-swarm-metrics
branch
2 times, most recently
from
05e6fd5
to
d15b42e
Compare
ballard26
force-pushed
the
producer-swarm-metrics
branch
from
d15b42e
to
3dcd450
Compare
StephanDollberg
previously approved these changes
Feb 29, 2024
ballard26
force-pushed
the
producer-swarm-metrics
branch
from
3dcd450
to
de6cc44
Compare
ballard26
force-pushed
the
producer-swarm-metrics
branch
from
de6cc44
to
f5f77cd
Compare
StephanDollberg
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds methods for accessing client_swarm's metrics API to the produce_swarm service class.
Backports Required
Release Notes