Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PESDLC-919 Constant data generation workload #16843

Merged
merged 17 commits into from
Mar 12, 2024

Conversation

savex
Copy link
Contributor

@savex savex commented Mar 1, 2024

Have a universal method that will provide constant data generation with configurable parameters using scale profiles

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

@savex savex force-pushed the PESDLC-919-topics-constant-workload branch from 59a90e5 to dfffcf1 Compare March 1, 2024 23:26
@savex savex force-pushed the PESDLC-919-topics-constant-workload branch 3 times, most recently from fcb1d3f to 8f96bea Compare March 4, 2024 18:54
@savex savex marked this pull request as ready for review March 4, 2024 20:02
@savex savex requested a review from ballard26 March 4, 2024 20:02
@savex
Copy link
Contributor Author

savex commented Mar 4, 2024

/ci-repeat 1

@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/45647#018e0b57-b3d0-459d-99e1-6691f079f413:

"rptest.tests.delete_records_test.DeleteRecordsTest.test_delete_records_concurrent_truncations.cloud_storage_enabled=True"

@savex savex force-pushed the PESDLC-919-topics-constant-workload branch 2 times, most recently from 3443039 to 532631b Compare March 6, 2024 20:39
self._max_record_size = max_record_size
self._keys = keys
self._unique_topics = unique_topics
self._unique_topics = unique_groups
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks bugged

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will note and correct in the first PR to follow.

Iterate.
"""
# Prepare librdkafka python client
kclient = PythonLibrdkafka(self.redpanda)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in the past I don't think this is great because this will run on the ducktape monitoring/client node.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and I had an idea to implement it inside remote script additions. But that is really a lot of effort at this point and we are already really tight on schedule. So this is merely a minimal load generated for the topic creation script.

nodes=[n]) for n in nodes
]
stddev = numpy.std(leaders_per_node)
error = stddev / (self._get_partition_count() / len(nodes))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar code exists in the MPT already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That code is operated on a per-topic basis and will run very long for 40k. This one is faster for our cause.

@StephanDollberg
Copy link
Member

Approved as per slack comment

@savex savex merged commit e5c78a0 into dev Mar 12, 2024
16 checks passed
@savex savex deleted the PESDLC-919-topics-constant-workload branch March 12, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants