cloud_storage: Improve stale_reader test #16853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test failed ocasionally when the test suite generated replacement segments with the same size as original. The test replaced segments 1:1. 30 segments were replaced with 30 new randomly generated segments. This caused the test to fail ocasionally when the size of the replacment matced the size of the original segment. This commit fixes that by replacing and merging segments. Every two old segments are replaced with one new. The manifest allows replacement segments to have any size if they are replacing more than one segment so the test can no longer fail this way.
andrwng
approved these changes
Mar 4, 2024
| @@ -564,7 +564,6 @@ std::vector<in_memory_segment> replace_segments( | |||
| auto bo = s.base_offset; | |||
| auto it = manifest.find(bo); | |||
| BOOST_REQUIRE(it != manifest.end()); | |||
| BOOST_REQUIRE(it->size_bytes != s.bytes.size()); | |||
There was a problem hiding this comment.
This change makes sense to me, since the batches generated are random. Out of curiosity, was the switch to replacing with merged_batch_types required also? Was there another failure mode in this test aside from this size check here?
|
Given this was flagged, I'll go ahead merge. If there are follow ups, please consider a follow-up PR. |
|
/backport v23.3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test failed ocasionally when the test suite generated replacement segments with the same size as original. The test replaced segments 1:1. 30 segments were replaced with 30 new randomly generated segments. This caused the test to fail ocasionally when the size of the replacment matced the size of the original segment.
This PR fixes that by replacing and merging segments. Every two old segments are replaced with one new. The manifest allows replacement segments to have any size if they are replacing more than one segment so the test can no longer fail this way.
Fixes #15679
Backports Required
Release Notes