cloud_storage: various non-functional changes #16886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within the remote partition reader, we maintain a segment reader previously named `_reader`. Since partition reader is also a reader, it can be confusing to read the code without that context. This renames it to `_seg_reader`.
andrwng
changed the title
abhijat
reviewed
Mar 5, 2024
| @@ -1130,7 +1130,7 @@ class remote_segment_batch_consumer : public storage::batch_consumer { | |||
| const model::ntp& ntp, | |||
| retry_chain_node& rtc) | |||
| : _config(conf) | |||
| , _parent(parent) | |||
| , _seg_reader(parent) | |||
There was a problem hiding this comment.
Do you think the c-tor argument should also be renamed for consistency?
abhijat
approved these changes
Mar 5, 2024
Lazin
approved these changes
Mar 5, 2024
|
could you also please backport this, it touches a lot of code so there could be merge conflicts when we will backport future PRs |
will do |
|
/backport v23.3.x |
|
/backport v23.2.x |
|
Failed to create a backport PR to v23.2.x branch. I tried: |
This was referenced Mar 5, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some non-functional changes that I noticed while reading through the read path:
_seg_reader, rather than_parentor_readerBackports Required
Release Notes