[v23.3.x] Metrics for transform logging #16913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
diff was a minor |
logger_probe for tracking metrics specific to individual transform
loggers:
- data_transforms_logger_events_total
- Total # of log events emitted by some transform.
- data_transforms_logger_events_dropped_total
- Total # of some transform's log events that were dropped due
to buffer capacity constraint.
- exported to BOTH /metrics and /public_metrics
manager_probe for tracking metrics generic to the logging::manager:
- data_transforms_log_manager_buffer_usage_ratio
- Current occupancy of the logging::manager's queues as a fraction
of total capacity. [0.0..1.0]
- data_transforms_log_manager_write_errors_total
- Total number of failures to produce log events to the transform
logs topic.
- exported ONLY to /metrics
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit c31ea7f)
One manager_probe per manager instance, initialized on manager::start
One logger_probe per log source, initialized on first manager::enqueue_log
Also moves some init/deinit logic to log_manager::{start,stop} to avoid
duplicate metric registrations
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit 6d59f92)
- Presence of metrics on both endpoints - Metrics values in contrived scenarios Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit b3a6637)
oleiman
force-pushed
the
vbotbuildovich/backport-16566-v23.3.x-28
branch
from
fcc431f
to
3d2d4e3
Compare
rockwotj
approved these changes
Mar 6, 2024
This was referenced Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #16566
Closes #16895