crypto/cmake: Fixed exact versioning #16936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockwotj
reviewed
Mar 7, 2024
src/v/crypto/CMakeLists.txt
Outdated
| @@ -1,4 +1,9 @@ | |||
| find_package(OpenSSL 3.0.9 EXACT REQUIRED) | |||
| if (RP_OPENSSL_VERSION) | |||
| message(STATUS "Searching for exactly OpenSSL version ${RP_OPENSSL_VERSION}") | |||
There was a problem hiding this comment.
i can remove it, was just a nice way of verifying it was working :)
Will not look for an exact version in the OSS build Fixes: redpanda-data#16932 Signed-off-by: Michael Boquard <michael@redpanda.com>
michael-redpanda
force-pushed
the
issues/16932-fix-oss-openssl
branch
from
e1405bc
to
72f9a9a
Compare
|
Force push
|
rockwotj
approved these changes
Mar 7, 2024
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will not look for an exact version in the OSS build
Fixes: #16932
Look to https://github.com/redpanda-data/vtools/pull/2552 to see how the exact OpenSSL version is selected
Backports Required
Release Notes