Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rptest: Fix cloud_retention_test #16943

Merged
merged 1 commit into from
Mar 9, 2024
Merged

rptest: Fix cloud_retention_test #16943

merged 1 commit into from
Mar 9, 2024

Conversation

Lazin
Copy link
Contributor

@Lazin Lazin commented Mar 7, 2024

Fix retention test. Previously, the throughput parameter was passed to the parameter that limited max number of messages. Because of that the test was only able to consume fixed number of messages in CDT. This commit fixes this and improves few other aspects (error handling and logging).

Fixes #15893

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@Lazin Lazin requested a review from andrwng March 7, 2024 19:12
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Mar 7, 2024 •
edited

new failures in https://buildkite.com/redpanda/redpanda/builds/45817#018e1ab0-f9ca-4570-8518-c507ae4dd388:

"rptest.tests.cloud_retention_test.CloudRetentionTest.test_cloud_retention.max_consume_rate_mb=None.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/45817#018e1ab0-f9c7-448a-8c27-72904d8ba75c:

"rptest.tests.cloud_retention_test.CloudRetentionTest.test_cloud_retention.max_consume_rate_mb=None.cloud_storage_type=CloudStorageType.ABS"

dotnwat
dotnwat previously approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the throughput parameter was passed to the parameter that limited max number of messages.

omg. nice catch!

@dotnwat
Copy link
Member

dotnwat commented Mar 8, 2024

looks like we may need to tweak a few tunables to get it to pass?

andrwng
andrwng reviewed Mar 8, 2024
View reviewed changes
tests/rptest/tests/cloud_retention_test.py Outdated
@@ -188,14 +189,15 @@ def check_total_size(include_below_start_offset):
msg_size,
readers=3,
loop=True,
max_msgs=max_read_msgs,
max_throughput_mb=max_read_msgs,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still seems a little strange that we're using a number of messages as a rate in mb. Maybe this should be max_consume_rate_mb?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, fixed that
no idea why it used like that before

@Lazin
rptest: Fix cloud_retention_test
042e4c2 
Fix retention test. Previously, the throughput parameter was passed to
the parameter that limited max number of messages. Because of that the
test was only able to consume fixed number of messages in CDT. This
commit fixes this and improves few other aspects (error handling and
logging).
@Lazin Lazin requested review from andrwng and dotnwat March 8, 2024 10:00
@vbotbuildovich
Copy link
Collaborator

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45863#018e1dc2-86ab-4644-a50b-e4ff9156c81d

@piyushredpanda piyushredpanda merged commit 0efdf10 into redpanda-data:dev Mar 9, 2024
16 checks passed
@piyushredpanda
Copy link
Contributor

Thanks for the fix, @Lazin !

@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v23.2.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-16943-v23.2.x-226 remotes/upstream/v23.2.x
git cherry-pick -x 042e4c2a8754106663bb02579715023117e35481

Workflow run logs.

This was referenced Mar 9, 2024
Closed
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotnwat dotnwat dotnwat approved these changes

@andrwng andrwng Awaiting requested review from andrwng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI Failure (Valid reads too low) in CloudRetentionTest.test_cloud_retention
5 participants
@Lazin @vbotbuildovich @dotnwat @piyushredpanda @andrwng