-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpk/transform/deploy: support deploying to multiple output topics #16950
rpk/transform/deploy: support deploying to multiple output topics #16950
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45824#018e1ad7-32cb-43ec-b800-5e13e99e3085 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45824#018e1aff-8d4f-4833-947e-7329888fad17 |
1e5b7b5
to
55cf542
Compare
Force push: revert changing the flag name. @r-vasquez do you have a recommendation for this? The latest push you can specify
|
@rockwotj Would https://pkg.go.dev/github.com/spf13/pflag#StringSliceVar We do that already in rpk, for example
We make sure to put |
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
55cf542
to
3578c89
Compare
Ah nice, yes that works for me thanks! (and done) |
Backports Required
Release Notes
Features
rpk transform deploy
now supports multiple output topics