wasm: add out_handle #16953
wasm: add out_handle #16953
Conversation
As a nice way to interop with out ptrs introduce out_handle_adapter similar to std::out_ptr_t but for handle. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45878#018e1ecf-fd84-43a0-ad30-736ebbb721c9 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45878#018e1ee1-8e1d-4ca8-82e5-1d56b4bb4425 |
|
The plan here is to merge this, then I'll send a followup PR to pull it out into utils so that this can be used by the crypto/openssl work |
There was a problem hiding this comment.
Looks good. Just to check my understanding - general idea is that
out_handleris convertible to T**- some allocation/initialization of an object happens on the other side of ffi
- pointer to initialized thing is assigned to
T* _raw_ptr ~out_handler()puts the T* underhandlermanagement- then the custom deleter is called during
~unique_ptr()
Do I have that right? Might benefit from a unit test under ffi_helpers or something if it's not a huge lift. Mostly provide an expressive example of ^^
Correct! It's pretty nifty. I am going to followup and move this into utils - I'll stick a test in there when this is pulled out. |
As a nice way to interop with out ptrs introduce out_handle
similar to std::out_ptr_t but for handle.
Backports Required
Release Notes