Ensure fragment_vector
fragments are always <= 128KiB
#16958
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
fragment_vector<T>::pow2_floor(size_t size)
wouldn't correctly calculate the nearest power of 2<= size
. This resulted in cases such as;not being true. This PR replaces
pow2_floor
with a standard library equivalent and adds a static assertion to ensure the size of fragments is always<= 128KiB
.Fixes #16957
Backports Required
Release Notes