tests: Tweak OMBValidationTest.test_max_connections #16969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45862#018e1d7f-4687-4f0e-af07-f4c66e4ea3d2 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45862#018e1d90-c212-41ca-8e08-2d6509efb0cc ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46490#018e5b78-3bc1-4532-bf32-4626ca21ad4f |
travisdowns
approved these changes
Mar 19, 2024
Minor tweaks to make this more stable: - Assign more nodes to client-swarm than OMB: The OMB workload is actually very gentle. The "hard" part is on the client-swarm side so more cores help there. - Reduce the wait time: This seems quite high and slows down the test a lot at higher connetion counts - Adjust client-wait ordering: The test is fundamentally broken in how it works as it doesn't properly calculate the amount of clients that can connect. We need to fix client-swarm such that we can wait for all clients connect and then just explicitly stop them at the end of the test. For now rearrange the waiting of the clients to finish such that it's more likely to pass (wait for OMB first and then for client swarms).
StephanDollberg
force-pushed
the
stephan/omb-vald-test-max-conn-tweaks
branch
from
814d25c
to
2481bcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor tweaks to make this more stable:
actually very gentle. The "hard" part is on the client-swarm side so
more cores help there.
lot at higher connetion counts
it works as it doesn't properly calculate the amount of clients that
can connect. We need to fix client-swarm such that we can wait for all
clients connect and then just explicitly stop them at the end of the
test. For now rearrange the waiting of the clients to finish such that
it's more likely to pass (wait for OMB first and then for client
swarms).
Backports Required
Release Notes